From 8d404506c4b0849ad9543e25f6c80ed17c7fafdb Mon Sep 17 00:00:00 2001 From: Alex Petrochenko Date: Thu, 14 May 2026 17:34:35 +0100 Subject: [PATCH] fix: resolve compiler warnings (from PR #8 by @waltje) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - weather.cpp: StaticJsonDocument → JsonDocument (ArduinoJson v7 API) - display.cpp: daylightStr buffer 16 → 32 bytes (suppress GCC sprintf warning) - ntp_client.cpp: remove unused weekday variable Applied manually due to repo layout mismatch in original PR. Co-authored-by: waltje Co-Authored-By: Claude Sonnet 4.6 --- firmware/clock_ntp_ota_v1.9/display.cpp | 2 +- firmware/clock_ntp_ota_v1.9/ntp_client.cpp | 1 - firmware/clock_ntp_ota_v1.9/weather.cpp | 2 +- src/clock_ntp_ota_v1.9.ino | 5 ++--- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/firmware/clock_ntp_ota_v1.9/display.cpp b/firmware/clock_ntp_ota_v1.9/display.cpp index d3f0d2e..2c618ee 100644 --- a/firmware/clock_ntp_ota_v1.9/display.cpp +++ b/firmware/clock_ntp_ota_v1.9/display.cpp @@ -168,7 +168,7 @@ void ICACHE_FLASH_ATTR displaySunTimes() { int daylightHours = daylightMinutes / 60; int daylightMins = daylightMinutes % 60; - char daylightStr[16]; + char daylightStr[32]; sprintf(daylightStr, "Day %dh %dm", daylightHours, daylightMins); display.setTextSize(1); diff --git a/firmware/clock_ntp_ota_v1.9/ntp_client.cpp b/firmware/clock_ntp_ota_v1.9/ntp_client.cpp index 4ee53d1..63d7bc7 100644 --- a/firmware/clock_ntp_ota_v1.9/ntp_client.cpp +++ b/firmware/clock_ntp_ota_v1.9/ntp_client.cpp @@ -16,7 +16,6 @@ bool ICACHE_FLASH_ATTR isDST(unsigned long epochTime) { int month = timeinfo->tm_mon + 1; // 1-12 int day = timeinfo->tm_mday; // 1-31 - int weekday = timeinfo->tm_wday; // 0=Sunday int hour = timeinfo->tm_hour; // Not DST: November - February diff --git a/firmware/clock_ntp_ota_v1.9/weather.cpp b/firmware/clock_ntp_ota_v1.9/weather.cpp index be56690..23df356 100644 --- a/firmware/clock_ntp_ota_v1.9/weather.cpp +++ b/firmware/clock_ntp_ota_v1.9/weather.cpp @@ -28,7 +28,7 @@ void ICACHE_FLASH_ATTR onWeatherResponse(void* optParm, AsyncHTTPRequest* reques Serial.printf("Weather response: %d bytes\n", payload.length()); // Parse JSON response - StaticJsonDocument<1536> doc; + JsonDocument doc; DeserializationError error = deserializeJson(doc, payload); if (!error) { diff --git a/src/clock_ntp_ota_v1.9.ino b/src/clock_ntp_ota_v1.9.ino index 5dece97..e05bdd6 100644 --- a/src/clock_ntp_ota_v1.9.ino +++ b/src/clock_ntp_ota_v1.9.ino @@ -161,7 +161,6 @@ bool isDST(unsigned long epochTime) { int month = timeinfo->tm_mon + 1; // 1-12 int day = timeinfo->tm_mday; // 1-31 - int weekday = timeinfo->tm_wday; // 0=Sunday int hour = timeinfo->tm_hour; // Not DST: November - February @@ -1101,7 +1100,7 @@ void ICACHE_FLASH_ATTR displaySunTimes() { int daylightMins = daylightMinutes % 60; // Format: "Day 9h 41m" or "9h 41m" - char daylightStr[16]; + char daylightStr[32]; sprintf(daylightStr, "Day %dh %dm", daylightHours, daylightMins); display.setTextSize(1); // Size 1 to fit more text @@ -2027,7 +2026,7 @@ void onWeatherResponse(void* optParm, AsyncHTTPRequest* request, int readyState) Serial.printf("✓ Weather response: %d bytes\n", payload.length()); // Parse JSON response - StaticJsonDocument<1536> doc; + JsonDocument doc; DeserializationError error = deserializeJson(doc, payload); if (!error) {