tobi/esp8266-weather-clock-opensource
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(web): clamp lastError before snprintf to prevent malformed JSON (Gemini review)

Browse Source
This commit is contained in:
Alex Petrochenko
2026-05-18 15:57:41 +01:00
parent 78bbd96f45
commit 7ebe341c06
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
firmware/weather_clock/web_server.cpp
+6 -1
View File
@@ -387,16 +387,21 @@ void ICACHE_FLASH_ATTR handleAPIStatus() {
void ICACHE_FLASH_ATTR handleAPIDebug() { void ICACHE_FLASH_ATTR handleAPIDebug() {
char buf[256]; char buf[256];
char errBuf[80];
server.setContentLength(CONTENT_LENGTH_UNKNOWN); server.setContentLength(CONTENT_LENGTH_UNKNOWN);
server.send(200, "application/json", ""); server.send(200, "application/json", "");
// Clamp lastError to prevent snprintf truncation causing malformed JSON
strncpy(errBuf, lastError.c_str(), sizeof(errBuf) - 1);
errBuf[sizeof(errBuf) - 1] = '\0';
snprintf_P(buf, sizeof(buf), snprintf_P(buf, sizeof(buf),
PSTR("{\"internet_connected\":%s,\"ntp_attempts\":%d,\"ntp_successes\":%d,\"last_error\":\"%s\",\"gateway\":\"%s\",\"dns\":\"%s\"}"), PSTR("{\"internet_connected\":%s,\"ntp_attempts\":%d,\"ntp_successes\":%d,\"last_error\":\"%s\",\"gateway\":\"%s\",\"dns\":\"%s\"}"),
internetConnected ? "true" : "false", internetConnected ? "true" : "false",
ntpAttempts, ntpAttempts,
ntpSuccesses, ntpSuccesses,
lastError.c_str(), errBuf,
WiFi.gatewayIP().toString().c_str(), WiFi.gatewayIP().toString().c_str(),
WiFi.dnsIP().toString().c_str()); WiFi.dnsIP().toString().c_str());
server.sendContent(buf); server.sendContent(buf);