AI Implementation feature(861): Admin Area Challenges: List, Import/Export and Add/Edit Modal (#40)

2026-07-22 20:26:30 +00:00
parent 1a40e5708a
commit 8dcbd48045
41 changed files with 4548 additions and 145 deletions
@@ -0,0 +1,102 @@
+process.env.DATABASE_PATH = ':memory:';
+process.env.THEMES_DIR = './themes';
+process.env.FRONTEND_DIST = './frontend/dist';
+process.env.UPLOAD_DIR = '/tmp/hipctf-challenges-api-test';
+process.env.UPLOAD_SIZE_LIMIT = '5mb';
+
+import * as fs from 'fs';
+import * as os from 'os';
+import * as path from 'path';
+import { Test } from '@nestjs/testing';
+import { INestApplication } from '@nestjs/common';
+import { HttpAdapterHost } from '@nestjs/core';
+import cookieParser from 'cookie-parser';
+import * as express from 'express';
+import request from 'supertest';
+import { CookieAccessInfo } from 'cookiejar';
+import { AppModule } from '../../backend/src/app.module';
+import { GlobalExceptionFilter } from '../../backend/src/common/filters/global-exception.filter';
+import { CsrfMiddleware } from '../../backend/src/common/middleware/csrf.middleware';
+import { ConfigService } from '@nestjs/config';
+import { initDb } from './db-helper';
+
+describe('Admin Challenges API - guards + structured validation', () => {
+  let app: INestApplication;
+  let adminToken: string;
+  let csrf: string;
+  const uploadDir = fs.mkdtempSync(path.join(os.tmpdir(), 'hipctf-challenges-api-'));
+
+  beforeAll(async () => {
+    process.env.UPLOAD_DIR = uploadDir;
+    const moduleRef = await Test.createTestingModule({ imports: [AppModule] }).compile();
+    app = moduleRef.createNestApplication();
+    app.use(cookieParser());
+    app.use(express.json({ limit: '1mb' }));
+    const csrfMw = new CsrfMiddleware(app.get(ConfigService));
+    app.use((req: any, res: any, next: any) => csrfMw.use(req, res, next));
+    app.useGlobalPipes(new (require('@nestjs/common').ValidationPipe)({ whitelist: true, forbidNonWhitelisted: false, transform: true }));
+    const httpAdapterHost = app.get(HttpAdapterHost);
+    app.useGlobalFilters(new GlobalExceptionFilter(httpAdapterHost));
+    await app.init();
+    await initDb(app);
+
+    const server = app.getHttpServer();
+    await request(server).post('/api/v1/auth/register-first-admin')
+      .send({ username: 'admin', password: 'Sup3rSecret!Pass' })
+      .expect(201);
+
+    const csrfPrime = await request(server).get('/api/v1/auth/csrf');
+    const csrfCookie = (csrfPrime.headers['set-cookie'] as unknown as string[] | undefined)?.find((c) => c.startsWith('csrf='));
+    csrf = csrfCookie ? decodeURIComponent(csrfCookie.split(';')[0].split('=')[1]) : '';
+
+    const login = await request(server).post('/api/v1/auth/login')
+      .set('Cookie', `csrf=${csrf}`)
+      .set('X-CSRF-Token', csrf)
+      .send({ username: 'admin', password: 'Sup3rSecret!Pass' })
+      .expect(201);
+    adminToken = login.body.accessToken;
+  });
+
+  afterAll(async () => {
+    await app.close();
+    if (fs.existsSync(uploadDir)) {
+      try {
+        fs.rmSync(uploadDir, { recursive: true, force: true });
+      } catch {
+        // ignore
+      }
+    }
+  });
+
+  it('rejects unauthenticated GET /api/v1/admin/challenges with 401', async () => {
+    await request(app.getHttpServer()).get('/api/v1/admin/challenges').expect(401);
+  });
+
+  it('rejects malformed import body with 400 and structured VALIDATION_FAILED details', async () => {
+    const server = app.getHttpServer();
+    const agent = request.agent(server);
+    await agent.get('/api/v1/auth/csrf');
+    const cookies: any = agent.jar.getCookies(CookieAccessInfo.All);
+    const csrfValue = cookies.find((c: any) => c.name === 'csrf').value;
+    const res = await agent
+      .post('/api/v1/admin/challenges/import')
+      .set('Authorization', `Bearer ${adminToken}`)
+      .set('X-CSRF-Token', csrfValue)
+      .send({ format: 'wrong', version: 'abc', challenges: 'not-an-array' });
+    expect(res.status).toBe(400);
+    expect(res.body?.code).toBe('VALIDATION_FAILED');
+    expect(Array.isArray(res.body?.details)).toBe(true);
+  });
+
+  it('returns 200 with the versioned envelope on export', async () => {
+    const res = await request(app.getHttpServer())
+      .get('/api/v1/admin/challenges/export')
+      .set('Authorization', `Bearer ${adminToken}`);
+    expect(res.status).toBe(200);
+    expect(res.headers['content-type']).toMatch(/application\/json/);
+    expect(res.headers['content-disposition']).toMatch(/attachment.*challenges-export-/);
+    expect(res.body?.format).toBe('hipctf-challenges');
+    expect(res.body?.version).toBe(1);
+    expect(Array.isArray(res.body?.challenges)).toBe(true);
+  });
+});