Commit Graph

9 Commits

Author SHA1 Message Date
e9b48b71a8
Fixing exit code error 2018-04-08 14:46:43 +02:00
69c8e42637
Removing unnecessary variable 2018-03-22 13:40:23 +01:00
c97bd1d37d
Handling of missing signatures 2018-03-22 13:34:56 +01:00
Bandie Canis
1b49b45439 Using gpg's passphrase request; new script. 2018-01-12 21:46:55 +01:00
Charles Duffy
cc43d546b2 Follow best practices for bash
- Use native bash math where doing so improves readability.
- Avoid illegal exit status codes (666 in impossible scenario).
- Avoid useless use of cat (`cat foo | bar` vs the more efficient `bar <foo`).
- Avoid needless echo pipelines (`echo foo | bar` vs `bar <<<"$foo"`).
- Never use a for loop to iterate over output from `find`; `for` loops depend
  on string-splitting, which is only available with globbing behavior. See
  http://mywiki.wooledge.org/DontReadLinesWithFor
- Use `read -s` to silence feedback rather than playing around with `stty`.
- Use `tput` to retrieve color codes correct for the current terminal rather
  than assuming a terminal compatible with ANSI color codes.
- Use a expression compatible with BSD `tr` in "passphrase-shredding" code.
  (BTW, I very much doubt that this code actually does any good; it's not a
  reasonable expectation that a new string assigned to a variable will actually
  be placed at the same location in memory).
- Implementations of `echo` which do anything other than print `-e` on output
  when `echo -e` is run are nonconformant with the POSIX spec for echo.
  Similarly, `echo -n` behavior is not defined by the standard. Avoid relying
  on either of these. (See http://pubs.opengroup.org/onlinepubs/009604599/utilities/echo.html,
  particularly the APPLICATION USAGE section).
- Always quote expansions to prevent string-splitting and glob-expansion
  (`"$i"`, not `$i`).
- Avoid `some_command; if [ $? -eq 0 ]; then` when `if some_command; then` can
  be used instead.
2015-12-30 15:46:52 -06:00
Bandie Kojote
dfe955413b Additional exit codes added + better shredding 2015-03-17 07:54:03 +01:00
Bandie Kojote
5e4766cfa8 Comments and words. 2015-03-17 07:23:23 +01:00
Bandie Kojote
d37cc28bf0 English is great. 2015-03-16 22:34:10 +01:00
Bandie Kojote
89131845f1 First commit and release. 2015-03-16 20:38:36 +01:00